Skip to content

Added tutorials folder from oneAPI-samples #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jimmytwei
Copy link

Added oneCCL tutorials from the oneAPI-samples repo.

set(CMAKE_C_COMPILER "icx")
set(CMAKE_CXX_COMPILER "icpx")
endif()
project (oneDNN)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneCCL?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@jimmytwei
Copy link
Author

@nikitaxgusev Any updates on this? The Jupyter notebook works but requires the oneAPI toolkits (for setvars and VTune). The notebook is used to teach developers how to use VTune to analyze performance for both CPU and GPU on oneCCL examples. Let me know if this is still appropriate for this repo. If not, we can keep this in the oneAPI-samples repo.

@Maria1Petrova
Copy link
Contributor

Hi @jimmytwei sorry for a delay, we will validate the functionality of the notebook and provide a feedback

@iBaer
Copy link

iBaer commented Jun 5, 2025

@jimmytwei
I can confirm the functionality of the notebook.
Since this tutorial will be bundled with oneCCL stand-alone, I would address this by adding a README.md to the folder.
This should explain that this tutorial requires a working oneAPI installation.
Also, I would add a couple of recommendations on how to launch this, e.g.
jupyter execute ./oneCCL_Getting_Started.ipynb
or via server (where possible)
jupyter notebook ./oneCCL_Getting_Started.ipynb

For other adjustments throughout (e.g. converting the tutorial into a full README guide) are not necessary for this PR in my opinion.

EDIT: If you need help by formulating a README doc, I can create this and add with a PR into your repo.

@Maria1Petrova (@srirajpaul for final Review):
Can you confirm this will be okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants