Skip to content

fix: make HTML video responsive #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davatron5000
Copy link

@davatron5000 davatron5000 commented Sep 28, 2023

This is an upstream fix for a downstream issue in the Understanding WCAG reflow page which was causing HTML video to cause two-dimensional scrolling.

Repro:

Expected:

  • No horizontal scroll bar

Actual:

  • Horizontal scroll bar

Fix:

  • Add max-width: 100% and height: auto rules to main video

Videos with a set [height] and [width] need both of these rules to maintain intrinsic aspect-ratio when resizing.

Original Pull Request: w3c/wcag#3430
Closes w3c/wcag#3401

@alastc
Copy link

alastc commented Sep 28, 2023

Looks good to me. We used to have that in place for WCAG 2.1 era version, but it got lost in the WAI redesign update.
@shawna-slh can you merge this? I don't have permission on this repo.

@shawna-slh shawna-slh requested a review from iadawn September 28, 2023 19:33
@remibetin remibetin self-assigned this May 3, 2024
@remibetin remibetin removed their assignment Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video causes horizontal scroll on page
4 participants