Skip to content

Enable golangci-lint. #2983

Open
Open
@jcscottiii

Description

@jcscottiii

Definition of done:

  • Replace the usage of golint with golangci-lint in Makefile
  • Linters to enabled
    • errcheck
    • gosimple
    • govet
    • ineffassign
    • staticcheck
    • typecheck
    • unused
    • containedctx
    • dupl
    • dogsled
    • errname
    • errorlint
    • exhaustive
    • exhaustruct
    • exportloopref
    • gochecknoglobals
    • gocognit
    • goconst
    • gocyclo
    • godot
    • godox
    • gofmt
    • goheader
    • gomoddirectives
    • gosec
    • importas
    • ireturn
    • lll
    • misspell
    • nakedret
    • nestif
    • nilerr
    • nilnil
    • nlreturn
    • noctx
    • prealloc
    • revive
    • unparam
    • usestdlibvars
  • Once replacing the linter, CI will fail. temporarily allow the lint stage to pass and add a TODO to remove it. add a reference to Fix all the lint issues after completing 2983 #2984

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions