Skip to content

Use paused animation for WPT fractional translation tests #53221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

Two WPT tests for view transitions with fractional translation fail when
run with the "--product=chrome" flag. The failures are due to minor, but
consistent, pixel differences near the edges of the rendered text,
caused by platform-specific subpixel rendering and anti-aliasing, which
are unavoidable when using fractional pixel values. This change uses
paused animation to ensure the tests pass reliably across platforms.

Bug: 356418728
Change-Id: I48228c49b721461f4d60bd732a7f20a7fcdba0b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6636275
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Gaston Rodriguez <gastonr@microsoft.com>
Commit-Queue: Eain Chen <eainchen@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1475079}

Two WPT tests for view transitions with fractional translation fail when
run with the "--product=chrome" flag. The failures are due to minor, but
consistent, pixel differences near the edges of the rendered text,
caused by platform-specific subpixel rendering and anti-aliasing, which
are unavoidable when using fractional pixel values. This change uses
paused animation to ensure the tests pass reliably across platforms.

Bug: 356418728
Change-Id: I48228c49b721461f4d60bd732a7f20a7fcdba0b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6636275
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Gaston Rodriguez <gastonr@microsoft.com>
Commit-Queue: Eain Chen <eainchen@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1475079}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@jonathan-j-lee
Copy link
Contributor

@web-platform-tests/interop please review?

Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine and would avoid flakiness.
Safari results look unchanged too

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit ff7b0f9 into master Jun 20, 2025
27 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-9a9be4a17f branch June 20, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants