[Gecko Bug 1959597] Fix tab crash with details-content enabled #53255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures that we don't try to share styles when there's a mismatch between the backing pseudo elements. This fixes a debug assert that's hit by the details element when ::details-content is enabled. Differential Revision: https://phabricator.services.mozilla.com/D254208 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1959597 gecko-commit: 876e9a090e1308e691bd29ffed6d85bb0d781539 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that we don't try to share styles when there's a mismatch between the backing pseudo elements.
This fixes a debug assert that's hit by the details element when ::details-content is enabled.
Differential Revision: https://phabricator.services.mozilla.com/D254208
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1959597
gecko-commit: 876e9a090e1308e691bd29ffed6d85bb0d781539
gecko-reviewers: emilio