Skip to content

upgrade(golangci-lint): v2.1.2 #4023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2025

Conversation

karamaru-alpha
Copy link
Contributor

@karamaru-alpha karamaru-alpha commented Apr 5, 2025

Summary

Upgrade golangci-lint to v2.1.2.

Details

  1. Upgrade golangci-lint by the migrate command and remove unnecessary configures. 0ef6efc

  2. Run golangci-lint run --fix. aa64f59

  3. Fix reporeted issues. 35270cc

Appendix

Signed-off-by: karamaru-alpha <mrnk3078@gmail.com>
Signed-off-by: karamaru-alpha <mrnk3078@gmail.com>
Signed-off-by: karamaru-alpha <mrnk3078@gmail.com>
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to increase the timeout ☺️

Signed-off-by: karamaru-alpha <mrnk3078@gmail.com>
Signed-off-by: karamaru-alpha <mrnk3078@gmail.com>
Signed-off-by: karamaru-alpha <mrnk3078@gmail.com>
@karamaru-alpha karamaru-alpha changed the title upgrade(golangci-lint): v1.57.2 to v2.0.2 upgrade(golangci-lint): v1.57.2 to v2.1.2 Apr 17, 2025
@karamaru-alpha karamaru-alpha changed the title upgrade(golangci-lint): v1.57.2 to v2.1.2 upgrade(golangci-lint): v2.1.2 Apr 17, 2025
Copy link
Collaborator

@nikola-jokic nikola-jokic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@nikola-jokic nikola-jokic merged commit f832b0b into actions:master Apr 17, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants