[macOS] Always use the latest major version of CodeQL Action #11946
+21
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paveliak
reviewed
Apr 4, 2025
| @@ -6,9 +6,24 @@ | |||
|
|
|||
| source ~/utils/utils.sh | |||
|
|
|||
| # Retrieve the latest major version of the CodeQL Action to use in the base URL for downloading the bundle. | |||
| releases=$(curl -s "https://api.github.com/repos/github/codeql-action/releases") | |||
There was a problem hiding this comment.
This needs to use a PAT like we do here or image generation could be throttled and fail
There was a problem hiding this comment.
Thanks! Previously we already used curl on Ubuntu or download_with_retry on macOS for another URL without the PAT (see line 25 in this file). Does download_with_retry help prevent the throttling?
Also, is this specific to macOS or do you recommend I use the PAT in the corresponding Ubuntu & Windows PRs?
There was a problem hiding this comment.
MacOS image generation has a higher risk of throttling so we have to use PATs. It is less of a problem for Windows/Linux images. You may build Url with this code
paveliak
reviewed
Apr 4, 2025
This was referenced Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the CodeQL Action major version, we now always use the latest major version of CodeQL Action.
Related issue: Supersedes #11928.
Check list