-
Notifications
You must be signed in to change notification settings - Fork 503
@v4 doesn't install the latest cli #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Separately I think it would be nice if the .NET runtime was not unconditionally installed: I believe it's redundant to install it if the SDK is the same version as the runtime, or a newer version. |
Hello @taspeotis, |
Hello @taspeotis 👋, The new setup-dotnet@v4 installation script is designed to be more reliable by running twice, resolving issues from the previous version (v3). Here's a breakdown of what happens:
By running these steps separately, we've fixed a problem (#387) where the dotnet executable was overwritten during each run, sometimes causing errors because the executable was still in use. In version 4, we've added an additional step that installs the Long-Term Support (LTS) version of the dotnet executable. This ensures that the executable is only downloaded once per workflow, which helps improve reliability (addressing PR #433). You can access the complete .NET Release Notes for further information. Let us know if you have any further questions or concerns about the two-step installation process! |
You can close it if it's working by design, but like I linked to: the code says it installs the latest version. You say: "The script first installs the latest .NET runtime to ensure you have the newest stable version of the dotnet executable." and then it installs LTS, not STS. STS is the latest. STS is the newest stable version. |
Description:
setup-dotnet/src/installer.ts
Lines 278 to 279 in 67a3573
This says it unconditionally installs "the latest stable version" but it doesn't, it installs LTS (8). STS would be the latest stable version (9).
Task version:
v4
Platform:
Runner type:
Repro steps:
Run the task, although note whatever version of .NET you ask for is irrelevant, this is about the step that unconditionally installed the dotnet runtime to get at
dotnet
.Expected behavior:
.NET 9 runtime is installed before the user specified version.
Actual behavior:
.NET 8 runtime is installed before the user specified version.
The text was updated successfully, but these errors were encountered: