Skip to content

Better support custom TLS situations when using a Docker #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
byjrack opened this issue Apr 7, 2025 · 2 comments
Open

Better support custom TLS situations when using a Docker #157

byjrack opened this issue Apr 7, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@byjrack
Copy link

byjrack commented Apr 7, 2025

Describe the feature or problem you’d like to solve

Currently there is no way (outside of forking i think) to support custom CA trust. Our enterprise controls are blocking the connections and outside of patching the server code or Dockerfile to include our custom cert and rehash the upstream image

Proposed solution

The easiest and least secure option would be a env we can pass in to use a custom transport w TLS verification disabled available via a env var flag.

https://github.com/github/github-mcp-server/blob/main/cmd/github-mcp-server/main.go#L141

And alternative would be to include a bootstrap model to use a volume mount to pull in a trusted cert at runtime. Possibly as part of the mcp settings schema or maybe it can use some of the CA trust support in the core of vscode.

Additional context

Image

@byjrack byjrack added the enhancement New feature or request label Apr 7, 2025
@SamMorrowDrums
Copy link
Collaborator

One option is just using the built binaries shared in the releases, as then they will use system and not docker trust chain.

https://github.com/github/github-mcp-server/releases/tag/v0.1.1

One comment suggested this had already been added to homebrew, so that could also be worth investigating to manage the binary.

@byjrack
Copy link
Author

byjrack commented Apr 7, 2025

Good call didn't notice the binary release outside of the image release. 😵‍💫

 "github": {
          "command": "github-mcp-server",
          "args": [ "stdio" ],
          "env": {
            "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_token}"
          }
        }

Easy tweak to the server ref just to test things out and couple quick tests seem to be fine. See it pushed to Homebrew as well so no path issues. Gatekeeper was being a bit picky for all those mac users, but easy to allow it when its blocked so that vscode can call it.

Still like to see the upstream team include TLS management in the Docker release so won't close the request just yet, but agreed a solid workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants