fix: octokit to use the correct enterprise url #844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seehait
force-pushed
the
fix/octokit-to-use-the-correct-enterprise-url
branch
from
144ee87 to
aa195b1
Compare
|
Need to setup a proper input anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #563
This is just a quick fix. We should define a new input to properly specify the custom server URL.
I found out that even when we override the
GITHUB_SERVER_URLenvironment variable, thegetDefaultBranchinitializes a new Octokit client without thebaseUrlvalue regardingGITHUB_SERVER_URL.Thus, the checkout action fails when we try to checkout to a private Github Enterprise Server repository with a misguided error messages.
I don't know the precise reasons why we haven't allowing any action users to customize the server URL via input though.
So, any comments are welcome.