Calculate PR branch fetch depth instead of hard-coding to 1000 #13796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpankow
approved these changes
Apr 21, 2023
takeru911
pushed a commit
to takeru911/dagster
that referenced
this pull request
Apr 29, 2023
…er-io#13796) ## Summary & Motivation Based off of actions/checkout#552 We should limit the fetch depth of the PR branch checkout to the bare minimum of what we need. ## How I Tested These Changes Applied script to local repository, made sure that the main branch checkout happened and the PR checkout happened with the calculated fetch depth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Based off of actions/checkout#552
We should limit the fetch depth of the PR branch checkout to the bare minimum of what we need.
How I Tested These Changes
Applied script to local repository, made sure that the main branch checkout happened and the PR checkout happened with the calculated fetch depth.