Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(node.js): update workflow #392

Merged
merged 1 commit into from
Mar 14, 2025
Merged

ci(node.js): update workflow #392

merged 1 commit into from
Mar 14, 2025

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Mar 13, 2025

This PR:

  • Removes Git credentials after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script; see related GitHub security post and related actions/checkout issue
  • Set check-latest to true, so that the actions/setup-node will check it is using the latest minor or hotfix Node version and use that instead of its cached version, this stops an issue like with 22.5.0 that introduced a regression and actions were still using that instead of 22.5.1
    • Node 22.5.0 was why Windows 22 was excluded to begin with, which has now been unexcluded
  • Adds --ignore-scripts arg to npm install calls, preventing any potentially harmful lifecycle scripts that may have snuck in

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 1804c26 into delvedor:main Mar 14, 2025
8 checks passed
@Fdawgs Fdawgs deleted the patch-2 branch March 14, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants