Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file_types): Add classification for Android file types #1321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jham
Copy link

@jham jham commented Jan 7, 2025

These are primarily used in Android development.

These are primarily used in Android development.
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nerdfonts has an actual android icon, that I am pretty sure would make more sense to use, at the very least for formats such as apk.

@@ -408,6 +416,7 @@ const EXTENSION_TYPES: Map<&'static str, FileType> = phf_map! {
"v" => FileType::Source, // V
"vb" => FileType::Source, // Visual Basic
"vsh" => FileType::Source, // Vertex shader
"xml" => FileType::Source, // eXtensible Markup Language
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nerdfonts contain specific xml icons, may be worth using that instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants