Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin_wakatime_repositories_visibility option #1052

Merged

Conversation

jopemachine
Copy link
Contributor

@jopemachine jopemachine commented May 14, 2022

Fixes #1049.

I tried to name the option (show_only_github_public_repos) as specific as possible.
It is working by checking the logined user's github repositories are accessible.
Tested only on my local computer.

I'd appreciate your letting me know if there are other related things to do.

Copy link
Owner

@lowlighter lowlighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
Thanks a lot for this nice addition 😄 !

Looks good overall, though I have some nitpicks about it but nothing too big 🙂

@jopemachine jopemachine changed the title Add plugin_wakatime_show_only_github_public_repos option Add plugin_wakatime_repositories_visibility option May 17, 2022
@lowlighter lowlighter merged commit c845f12 into lowlighter:master May 20, 2022
@lowlighter
Copy link
Owner

Thanks a lot for your contribution 🎉 !

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(plugins/wakatime): support to exclude private repositories in wakatime plugin
2 participants