-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin_wakatime_repositories_visibility
option
#1052
Merged
lowlighter
merged 5 commits into
lowlighter:master
from
jopemachine:feat-show-only-public-github-repo
May 20, 2022
Merged
Add plugin_wakatime_repositories_visibility
option
#1052
lowlighter
merged 5 commits into
lowlighter:master
from
jopemachine:feat-show-only-public-github-repo
May 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowlighter
requested changes
May 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thanks a lot for this nice addition 😄 !
Looks good overall, though I have some nitpicks about it but nothing too big 🙂
plugin_wakatime_show_only_github_public_repos
optionplugin_wakatime_repositories_visibility
option
lowlighter
reviewed
May 19, 2022
lowlighter
approved these changes
May 20, 2022
Thanks a lot for your contribution 🎉 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1049.
I tried to name the option (
show_only_github_public_repos
) as specific as possible.It is working by checking the
logined
user's github repositories are accessible.Tested only on my local computer.
I'd appreciate your letting me know if there are other related things to do.