Update X-RapidAPI-Host to yh-finance.p.rapidapi.com #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As shown in the latest YH Finance API page, the X-RapidAPI-Host has been changed from apidojo-yahoo-finance-v1.p.rapidapi.com to yh-finance.p.rapidapi.com. Updating obsoleted URL to the new one to avoid 403 error when trying to get the stock chart from this API.
|
Nice debug! LGTM, can you also patch the mocked data: So it can pass tests too ? |
|
@lowlighter Yeap I've changed the test file too! Seems working now~ |
|
Thanks a lot for your contribution 🎉 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in the latest YH Finance API page, the X-RapidAPI-Host has been changed from apidojo-yahoo-finance-v1.p.rapidapi.com to yh-finance.p.rapidapi.com. A related discussion can be found in #931.
Updating obsoleted URL to the new one to avoid 403 error when trying to get the stock chart from this API.