fix(serve): make error messages for invalid fetch() clearer #18260
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 8:57 PM PT - Mar 18th, 2025
❌ @DonIsaac, your commit 9eb2216 has 2 failures in
🧪 try this PR locally: bunx bun-pr 18260 |
paperclover
approved these changes
Mar 20, 2025
paperclover
requested changes
Mar 20, 2025
| return global.throwInvalidArguments("Expected fetch() to be a function", .{}); | ||
| if (onRequest_.isUndefined()) { | ||
| return global.throwInvalidArguments( | ||
| "Bun.serve() requires a fetch() function to handle incoming requests. For more information, see " ++ bun_docs_url ++ "api/http#bun-serve", |
There was a problem hiding this comment.
i thought that we should accept routes and/or fetch, so this error message isn't exactly right.
also getTruthy avoids undefined already so this is not going to be hit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes errors thrown when
Bun.serveis passed an invalidfetch()argument clearer. Partially addresses #18255.It looks like this issue is causing problems within SST; I don't see a fetch() function being passed to Bun.serve.
How did you verify your code works?