Skip to content

Commit bffaacf

Browse files
authoredDec 18, 2024
ci: Do not persist credentials after checkout (#89)
See actions/checkout#485 and https://johnstawinski.com/2024/01/11/playing-with-fire-how-we-executed-a-critical-supply-chain-attack-on-pytorch/ In short, it is a terrible idea to persist even our default credentials after checkout. There's no call for that, so we will now set `persist-credentials: false` on all checkout actions.
1 parent e2ef7a9 commit bffaacf

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎.github/workflows/release-please.yml

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ jobs:
2323
- uses: actions/checkout@v4
2424
with:
2525
ref: ${{ github.event.after }}
26+
persist-credentials: false
2627
if: ${{ steps.release.outputs.release_created }}
2728

2829
- run: npm run build

0 commit comments

Comments
 (0)
Failed to load comments.