Skip to content

Commit d0f1d1a

Browse files
authoredDec 18, 2024
ci: Do not persist credentials after checkout (#71)
See actions/checkout#485 and https://johnstawinski.com/2024/01/11/playing-with-fire-how-we-executed-a-critical-supply-chain-attack-on-pytorch/ In short, it is a terrible idea to persist even our default credentials after checkout. There's no call for that, so we will now set `persist-credentials: false` on all checkout actions.
1 parent c038b63 commit d0f1d1a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed
 

‎.github/workflows/release.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
- uses: actions/checkout@v4
2626
with:
2727
submodules: true
28+
persist-credentials: false
2829

2930
- name: Install deps
3031
run: |
@@ -99,6 +100,8 @@ jobs:
99100
runs-on: windows-latest
100101
steps:
101102
- uses: actions/checkout@v4
103+
with:
104+
persist-credentials: false
102105

103106
- name: Set version number
104107
shell: bash
@@ -196,6 +199,8 @@ jobs:
196199
with:
197200
repository: '${{ secrets.HOMEBREW_TAP_REPO }}'
198201
fetch-depth: 0 # The entire repo history, so we can push an update
202+
# To push to this repo, an explicit token is used to authenticate.
203+
persist-credentials: false
199204

200205
- name: Wipe source and formula folders
201206
run: |
@@ -211,6 +216,7 @@ jobs:
211216
uses: actions/checkout@v4
212217
with:
213218
path: shaka-lab-source
219+
persist-credentials: false
214220

215221
- name: Finish staging tap repo
216222
run: |

0 commit comments

Comments
 (0)
Failed to load comments.