Skip to content

Commit 225dd1b

Browse files
queervioletqueerviolet
queerviolet
authored and
queerviolet
committed
Husky prepush triggers are failing when they shouldn't. Kill it for now.
1 parent 5cef09c commit 225dd1b

File tree

3 files changed

+1
-38
lines changed

3 files changed

+1
-38
lines changed

README.md

-8
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,3 @@ I use `import` and `export` in `.jsx` files, unless `require` makes for cleaner
132132
I use two spaces, no semi-colons, and generally prefer a less strict version of
133133
[NPM's funny coding style](https://docs.npmjs.com/misc/coding-style). My lint config is
134134
in [eslintrc.js](eslintrc.js).
135-
136-
## I'm picky
137-
138-
I come with [husky](https://github.com/typicode/husky) to prevent you from pushing with broken
139-
tests or broken lint. This is really, really helpful in maintaining tests that are useful
140-
and code that follows at least some style. Please don't turn off this helpful thing.
141-
142-
If you want to live in a state of sin, you can remove or edit the `prepush` package script.

package.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,7 @@
2121
"test-watch": "npm run test -- --watch --reporter=min",
2222
"seed": "node db/seed.js",
2323
"lint": "esw . --ignore-path .gitignore --ext '.js,.jsx'",
24-
"lint-watch": "npm run lint -- -w",
25-
"prepush": "npm run lint && npm run test"
24+
"lint-watch": "npm run lint -- -w"
2625
},
2726
"repository": {
2827
"type": "git",
@@ -92,7 +91,6 @@
9291
"eslint-plugin-react": "^6.10.3",
9392
"eslint-plugin-standard": "^3.0.1",
9493
"eslint-watch": "^3.1.0",
95-
"husky": "^0.13.3",
9694
"mocha": "^3.1.2",
9795
"nodemon": "^1.11.0",
9896
"supertest": "^3.0.0",

yarn.lock

-27
Original file line numberDiff line numberDiff line change
@@ -1196,10 +1196,6 @@ chokidar@^1.4.3:
11961196
optionalDependencies:
11971197
fsevents "^1.0.0"
11981198

1199-
ci-info@^1.0.0:
1200-
version "1.0.0"
1201-
resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-1.0.0.tgz#dc5285f2b4e251821683681c381c3388f46ec534"
1202-
12031199
cipher-base@^1.0.0, cipher-base@^1.0.1:
12041200
version "1.0.3"
12051201
resolved "https://registry.yarnpkg.com/cipher-base/-/cipher-base-1.0.3.tgz#eeabf194419ce900da3018c207d212f2a6df0a07"
@@ -2193,10 +2189,6 @@ find-cache-dir@^0.1.1:
21932189
mkdirp "^0.5.1"
21942190
pkg-dir "^1.0.0"
21952191

2196-
find-parent-dir@^0.3.0:
2197-
version "0.3.0"
2198-
resolved "https://registry.yarnpkg.com/find-parent-dir/-/find-parent-dir-0.3.0.tgz#33c44b429ab2b2f0646299c5f9f718f376ff8d54"
2199-
22002192
find-up@^1.0.0:
22012193
version "1.1.2"
22022194
resolved "https://registry.yarnpkg.com/find-up/-/find-up-1.1.2.tgz#6b2e9822b1a2ce0a60ab64d610eccad53cb24d0f"
@@ -2564,15 +2556,6 @@ https-browserify@0.0.1:
25642556
version "0.0.1"
25652557
resolved "https://registry.yarnpkg.com/https-browserify/-/https-browserify-0.0.1.tgz#3f91365cabe60b77ed0ebba24b454e3e09d95a82"
25662558

2567-
husky@^0.13.3:
2568-
version "0.13.3"
2569-
resolved "https://registry.yarnpkg.com/husky/-/husky-0.13.3.tgz#bc2066080badc8b8fe3516e881f5bc68a57052ff"
2570-
dependencies:
2571-
chalk "^1.1.3"
2572-
find-parent-dir "^0.3.0"
2573-
is-ci "^1.0.9"
2574-
normalize-path "^1.0.0"
2575-
25762559
iconv-lite@0.4.13, iconv-lite@~0.4.13:
25772560
version "0.4.13"
25782561
resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.13.tgz#1f88aba4ab0b1508e8312acc39345f36e992e2f2"
@@ -2688,12 +2671,6 @@ is-callable@^1.1.1, is-callable@^1.1.2, is-callable@^1.1.3:
26882671
version "1.1.3"
26892672
resolved "https://registry.yarnpkg.com/is-callable/-/is-callable-1.1.3.tgz#86eb75392805ddc33af71c92a0eedf74ee7604b2"
26902673

2691-
is-ci@^1.0.9:
2692-
version "1.0.10"
2693-
resolved "https://registry.yarnpkg.com/is-ci/-/is-ci-1.0.10.tgz#f739336b2632365061a9d48270cd56ae3369318e"
2694-
dependencies:
2695-
ci-info "^1.0.0"
2696-
26972674
is-date-object@^1.0.1:
26982675
version "1.0.1"
26992676
resolved "https://registry.yarnpkg.com/is-date-object/-/is-date-object-1.0.1.tgz#9aa20eb6aeebbff77fbd33e74ca01b33581d3a16"
@@ -3457,10 +3434,6 @@ normalize-package-data@^2.3.2:
34573434
semver "2 || 3 || 4 || 5"
34583435
validate-npm-package-license "^3.0.1"
34593436

3460-
normalize-path@^1.0.0:
3461-
version "1.0.0"
3462-
resolved "https://registry.yarnpkg.com/normalize-path/-/normalize-path-1.0.0.tgz#32d0e472f91ff345701c15a8311018d3b0a90379"
3463-
34643437
normalize-path@^2.0.1:
34653438
version "2.0.1"
34663439
resolved "https://registry.yarnpkg.com/normalize-path/-/normalize-path-2.0.1.tgz#47886ac1662760d4261b7d979d241709d3ce3f7a"

0 commit comments

Comments
 (0)