Skip to content

issues Search Results · repo:FullstackAcademy/fsg language:JavaScript

Filter by

31 results
 (88 ms)

31 results

inFullstackAcademy/fsg (press backspace or delete to remove)

FullstackAcademy/fsg
Front-end tests are difficult to enable

FSG by default loads the home state upon initialization. This makes it difficult to unit test components. To have working front-end tests, students must either: - Architect all their services as belonging ...
  • glebec
  • Opened 
    on Oct 10, 2016
  • #88

FullstackAcademy/fsg
Confusing disparity with Facebook OAuth

Facebook uses a clientId in the strategy, but an APP_ID in the production environment variable. See https://github.com/FullstackAcademy/fsg/blob/master/generated/server/env/production.js#L18. While students ...
  • glebec
  • Opened 
    on Oct 3, 2016
  • #87

FullstackAcademy/fsg
Tests are not transpiled

Eventually the standard Node version will contain enough ES6 so that this becomes moot, but at least for now, FSG transpiles server browser code but not test code. This can cause problems e.g. on Codeship ...
  • glebec
  • Opened 
    on Sep 30, 2016
  • #86

FullstackAcademy/fsg
Rename `public` to `build`

Students very often make the mistake of putting things in public, or changing files in public — often to the point of removing public from .gitignore. Part of the problem is we ve used public for static ...
  • glebec
  • Opened 
    on Sep 29, 2016
  • #85

FullstackAcademy/fsg
Possibly change returned rejected promise to thrown error?

https://github.com/FullstackAcademy/fsg/blob/master/generated/browser/js/fsa/fsa-pre-built.js#L93 returns a rejected promise with an object that has a message. Is there any compelling reason to do this ...
  • glebec
  • Opened 
    on Sep 19, 2016
  • #83

FullstackAcademy/fsg
Session User not being created

Session.create is being called without a sessionId on line 55 in fsa-pre-built.js. This results in continuous get requests to /session after user has logged in since this.isAuthenticated() returns false ...
  • Abazhenov
  • 1
  • Opened 
    on Sep 14, 2016
  • #75

FullstackAcademy/fsg
Exec on promise chain in twitter oauth

Doing the FSG auth session right now and just noticed that there s an exec method call on the twitter oauth config file on line 30. Not on google, probably a mongoose relic?
  • zekenie
  • Opened 
    on Sep 14, 2016
  • #74

FullstackAcademy/fsg
Separate dev / production linting

Pursuant to a conversation between @joedotjs and myself, the no-debugger rule — currently set to level 2 (error) to prevent committing a debugger statement — causes the lint task to fail, in turn stopping ...
  • glebec
  • Opened 
    on Sep 13, 2016
  • #73

FullstackAcademy/fsg
Browser tests failing

It would appear something is wrong with sessions. AuthService ✔ should be an object isAuthenicated ✖ should return true if a Session exists ✔ should return false if a Session does ...
  • glebec
  • 2
  • Opened 
    on Sep 13, 2016
  • #71

FullstackAcademy/fsg
Proposed Change to User Hooks

It s a known bug/feature/who knows that the beforeValidate method in sequelize runs twice. I ran into this when trying to allow users to change passwords. When creating a user the if(user.changed( password ...
  • bighitbiker3
  • 1
  • Opened 
    on Aug 2, 2016
  • #64
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue search results · GitHub