Skip to content

codegen: Fix SQLite integer and primary key generation #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Huliiiiii
Copy link

@Huliiiiii Huliiiiii commented Apr 27, 2025

PR Info

  • Dependencies:
  • Dependents:

New Features

Bug Fixes

Breaking Changes

Changes

  • If database backend is sqlite, interger will be generated as i64 instead of i32
  • Fix sqlite primary key generated as Option

@Huliiiiii Huliiiiii changed the title codegen: Generate sqlite integer as i64 codegen: Fix SQLite integer and primary key generation Apr 27, 2025
@tyt2y3
Copy link
Member

tyt2y3 commented Apr 27, 2025

thank you. I'd like to have an option to choose whether to map it to i32/i64.
another thing we can do (in sea-schema) is to recognize bigint as a special type, and return BigInt, similar to how SmallInt is handled now.

1 similar comment
@tyt2y3
Copy link
Member

tyt2y3 commented Apr 27, 2025

thank you. I'd like to have an option to choose whether to map it to i32/i64.
another thing we can do (in sea-schema) is to recognize bigint as a special type, and return BigInt, similar to how SmallInt is handled now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants