-
-
Notifications
You must be signed in to change notification settings - Fork 585
Add exists method to PaginatorTrait with tests #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.1.x
Are you sure you want to change the base?
Conversation
Thank you! I'll review this a bit later. TODO for myself: also merge this in If you're ok with using your own unreleased fork of 1.1.x until 2.0.0 comes out, you can change the base of the PR to |
Can this be released as a patch 1.1.x release? I think it should be fine since it does not have any breaking changes. That way I can continue to use the crates.io version. |
Yeah, I assumed that you may want that. I'm not the one making (the decisions about) releases, but @tyt2y3 will probably do this |
@@ -69,7 +70,7 @@ pub async fn init_1(ctx: &TestContext, link: bool) { | |||
total: Set(10.into()), | |||
bakery_id: Set(42), | |||
customer_id: Set(11), | |||
placed_at: Set(DateTime::UNIX_EPOCH), | |||
placed_at: Set(ChronoDateTime::UNIX_EPOCH.naive_utc()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did this because this was throwing a deprecation warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Everything looks good to me!
@tyt2y3. we can merge this and then cherry-pick into master
too
Introduce an
exists
method to thePaginatorTrait
to efficiently check for record existence.Fixes #730.