Skip to content

Enforce engineStrict #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piranna opened this issue Apr 24, 2025 · 1 comment
Open

Enforce engineStrict #1286

piranna opened this issue Apr 24, 2025 · 1 comment
Labels
feature request New feature or request to improve the current logic

Comments

@piranna
Copy link

piranna commented Apr 24, 2025

Description:

Add a new value engineStrict for the node-version config field, so it will pick the Node.js version number from package.json file engineStrict field. This will require that the repository source code is checkout before using setup-node action, but can be defined in the documentation, or exit with an error if the package.json file is not found. If package.json file is found but the engineStrict field is not available, then we can use the default Node.js version, showing a warning instead.

Justification:

To have a single place to config the Node.js version value instead of two (package.json and GitHub Action yaml file).

Are you willing to submit a PR?

Yes, I can do it, if there's interest on merging it.

@piranna piranna added feature request New feature or request to improve the current logic needs triage labels Apr 24, 2025
@mahabaleshwars
Copy link

Hi @piranna,
Thank you for creating this feature request. We will investigate it and provide feedback as soon as we have some updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants