Skip to content

issues Search Results · repo:ari-os310/Moodify language:JavaScript

Filter by

9 results
 (82 ms)

9 results

inari-os310/Moodify (press backspace or delete to remove)

ari-os310/Moodify
Clicking delete prompts warning

The way the delete function is set up right now, someone could accidentally delete an affirmation without first being prompted to confirm. Clicking delete should prompt either an alert or a modal box prompting ...
good first issue
  • ari-os310
  • Opened 
    on Jun 20, 2020
  • #9

ari-os310/Moodify
Delete Affirmation Cursor Edit

Hovering over the _ x _ in the affirmations expands and turns red to signal to delete . However, the cursor for hovering over affirmation turns into a pointer while the cursor over _ x _ turns into text ...
good first issue
  • ari-os310
  • Opened 
    on Jun 20, 2020
  • #8

ari-os310/Moodify
Voice list needs to be organized

Currently, the menu bar toggles open to a list of voices that comes from the Text-to-Speech API. The voices are rendered without any order or organization. This issue intends to: - sort voices by language ...
good first issue
  • ari-os310
  • Opened 
    on Jun 20, 2020
  • #7

ari-os310/Moodify
Use promises instead of callbacks

https://github.com/ari-os310/Moodify/blob/6a885598ab959c2b36ff03c17dbb63dbe7759df9/client/src/moodify-db-helpers.js#L78
  • vegetabill
  • Opened 
    on Jun 8, 2020
  • #6

ari-os310/Moodify
Rename moodify-db-helpers to reduce confusion

client/src/moodify-db-helpers.js shouldn t really have db in the name as it is a client to call the server API
  • vegetabill
  • Opened 
    on Jun 8, 2020
  • #5

ari-os310/Moodify
Mood should be a path param

/mood in this path has no meaning. It would work better as a path parameter as it is in the get path above. /moods/:mood/affirmation and not included in the body (or ignored if in the body) https://github.com/ari-os310/Moodify/blob/6a885598ab959c2b36ff03c17dbb63dbe7759df9/index.js#L64 ...
  • vegetabill
  • Opened 
    on Jun 8, 2020
  • #4

ari-os310/Moodify
Replace effect code with `useEffect`

This logic check belongs in a useEffect hook https://github.com/ari-os310/Moodify/blob/6a885598ab959c2b36ff03c17dbb63dbe7759df9/client/src/components/AvatarPage.js#L23-L27
  • vegetabill
  • Opened 
    on Jun 7, 2020
  • #3

ari-os310/Moodify
Voices probably changes very infrequently and can be cached

I m not sure this counts toward the limit but even if not it could be cached https://github.com/ari-os310/Moodify/blob/0e68d084ca69a31016efbdc49254ca0938adf3e2/index.js#L117-L122
  • vegetabill
  • 1
  • Opened 
    on May 13, 2020
  • #2

ari-os310/Moodify
UnhandledPromiseRejectionWarning: error: database "moodify_db" does not exist

Please add DB setup instructions to the README if it s required to run the app
  • vegetabill
  • Opened 
    on Apr 22, 2020
  • #1
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Press the
/
key to activate the search input again and adjust your query.
Issue origami icon

Learn how you can use GitHub Issues to plan and track your work.

Save views for sprints, backlogs, teams, or releases. Rank, sort, and filter issues to suit the occasion. The possibilities are endless.Learn more about GitHub Issues
ProTip! 
Restrict your search to the title by using the in:title qualifier.
Issue search results · GitHub