Skip to content

Commit 33b0d25

Browse files
author
James Halliday
committed
opts.outputs in the api example, test for output writable stream use-case
1 parent 8698ca6 commit 33b0d25

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed

readme.markdown

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ var fs = require('fs');
9494

9595
var files = [ './files/x.js', './files/y.js' ];
9696
var b = browserify(files);
97-
b.plugin('factor-bundle', { o: [ 'bundle/x.js', 'bundle/y.js' ] });
97+
b.plugin('factor-bundle', { outputs: [ 'bundle/x.js', 'bundle/y.js' ] });
9898
b.bundle().pipe(fs.createWriteStream('bundle/common.js'));
9999
```
100100

test/outfile.js renamed to test/outputs.js

+28-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ var files = [
1515
var tmpdir = tmp() + '/factor-bundle-' + Math.random();
1616
mkdirp.sync(tmpdir);
1717

18-
test('outputs api', function (t) {
18+
test('file outputs', function (t) {
1919
t.plan(2);
2020
var b = browserify(files);
2121
b.plugin(factor, {
@@ -41,3 +41,30 @@ test('outputs api', function (t) {
4141
} } });
4242
});
4343
});
44+
45+
test('stream outputs', function (t) {
46+
t.plan(2);
47+
var sources = {}, pending = 3;
48+
function write (key) {
49+
return concat(function (body) {
50+
sources[key] = body.toString('utf8');
51+
if (-- pending === 0) done();
52+
});
53+
}
54+
55+
var b = browserify(files);
56+
b.plugin(factor, { outputs: [ write('x'), write('y') ] });
57+
b.bundle().pipe(write('common'));
58+
59+
function done () {
60+
var common = sources.common, x = sources.x, y = sources.y;
61+
62+
vm.runInNewContext(common + x, { console: { log: function (msg) {
63+
t.equal(msg, 55500);
64+
} } });
65+
66+
vm.runInNewContext(common + y, { console: { log: function (msg) {
67+
t.equal(msg, 333);
68+
} } });
69+
}
70+
});

0 commit comments

Comments
 (0)