Skip to content

Commit 4bbb7ec

Browse files
committed
adds checks for db changes in tests for robustness
1 parent 0b179e7 commit 4bbb7ec

File tree

2 files changed

+20
-5
lines changed

2 files changed

+20
-5
lines changed

tests/test_wave_01.py

+17-5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
from app.models.task import Task
2+
3+
14
def test_get_tasks_no_saved_tasks(client):
25
# Act
36
response = client.get("/tasks")
@@ -74,6 +77,11 @@ def test_create_task_with_none_completed_at(client):
7477
"is_complete": False
7578
}
7679
}
80+
new_task = Task.query.get(1)
81+
assert new_task
82+
assert new_task.title == "A Brand New Task"
83+
assert new_task.description == "Test Description"
84+
assert new_task.completed_at == None
7785

7886

7987
def test_update_task(client, one_task):
@@ -96,6 +104,10 @@ def test_update_task(client, one_task):
96104
"is_complete": False
97105
}
98106
}
107+
task = Task.query.get(1)
108+
assert task.title == "Updated Task Title"
109+
assert task.description == "Updated Test Description"
110+
assert task.completed_at == None
99111

100112

101113
def test_update_task_not_found(client):
@@ -123,11 +135,7 @@ def test_delete_task(client, one_task):
123135
assert response_body == {
124136
"details": 'Task 1 "Go on my daily walk 🏞" successfully deleted'
125137
}
126-
127-
# Make another request to
128-
# check that the task was deleted
129-
response = client.get("/tasks/1")
130-
assert response.status_code == 404
138+
assert Task.query.get(1) == None
131139

132140

133141
def test_delete_task_not_found(client):
@@ -138,6 +146,7 @@ def test_delete_task_not_found(client):
138146
# Assert
139147
assert response.status_code == 404
140148
assert response_body == None
149+
assert Task.query.all() == []
141150

142151

143152
def test_create_task_must_contain_title(client):
@@ -154,6 +163,7 @@ def test_create_task_must_contain_title(client):
154163
assert response_body == {
155164
"details": "Invalid data"
156165
}
166+
assert Task.query.all() == []
157167

158168

159169
def test_create_task_must_contain_description(client):
@@ -170,6 +180,7 @@ def test_create_task_must_contain_description(client):
170180
assert response_body == {
171181
"details": "Invalid data"
172182
}
183+
assert Task.query.all() == []
173184

174185

175186
def test_create_task_must_contain_completed_at(client):
@@ -186,3 +197,4 @@ def test_create_task_must_contain_completed_at(client):
186197
assert response_body == {
187198
"details": "Invalid data"
188199
}
200+
assert Task.query.all() == []

tests/test_wave_03.py

+3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import unittest
22
from unittest.mock import Mock, patch
3+
from datetime import datetime
4+
from app.models.task import Task
35

46

57
def test_toggle_complete_on_incomplete_task(client, one_task):
@@ -35,6 +37,7 @@ def test_toggle_complete_on_incomplete_task(client, one_task):
3537
"is_complete": True
3638
}
3739
}
40+
assert Task.query.get(1).completed_at
3841

3942

4043
def test_toggle_complete_on_complete_task(client, completed_task):

0 commit comments

Comments
 (0)