[Refactor] CopyDataProperties tests are the same in ES2020 as in ES2018

Author: ljharb

2018/CopyDataProperties.js

@@ -2,11 +2,12 @@
 
 var $TypeError = require('es-errors/type');
 var isObject = require('es-object-atoms/isObject');
-
 var callBound = require('call-bound');
-var forEach = require('../helpers/forEach');
 var OwnPropertyKeys = require('own-keys');
 
+var every = require('../helpers/every');
+var forEach = require('../helpers/forEach');
+
 var $isEnumerable = callBound('Object.prototype.propertyIsEnumerable');
 
 var CreateDataProperty = require('./CreateDataProperty');
@@ -25,14 +26,9 @@ module.exports = function CopyDataProperties(target, source, excludedItems) {
 		throw new $TypeError('Assertion failed: "target" must be an Object');
 	}
 
-	if (!IsArray(excludedItems)) {
+	if (!IsArray(excludedItems) || !every(excludedItems, isPropertyKey)) {
 		throw new $TypeError('Assertion failed: "excludedItems" must be a List of Property Keys');
 	}
-	for (var i = 0; i < excludedItems.length; i += 1) {
-		if (!isPropertyKey(excludedItems[i])) {
-			throw new $TypeError('Assertion failed: "excludedItems" must be a List of Property Keys');
-		}
-	}
 
 	if (typeof source === 'undefined' || source === null) {
 		return target;
@@ -51,7 +47,7 @@ module.exports = function CopyDataProperties(target, source, excludedItems) {
 		});
 
 		var enumerable = $isEnumerable(fromObj, nextKey) || (
-		// this is to handle string keys being non-enumerable in older engines
+			// this is to handle string keys being non-enumerable in older engines
 			typeof source === 'string'
 			&& nextKey >= 0
 			&& IsInteger(ToNumber(nextKey))

2019/CopyDataProperties.js

@@ -4,8 +4,9 @@ var $TypeError = require('es-errors/type');
 var isObject = require('es-object-atoms/isObject');
 var callBound = require('call-bound');
 var OwnPropertyKeys = require('own-keys');
-var forEach = require('../helpers/forEach');
+
 var every = require('../helpers/every');
+var forEach = require('../helpers/forEach');
 
 var $isEnumerable = callBound('Object.prototype.propertyIsEnumerable');
 
@@ -46,7 +47,7 @@ module.exports = function CopyDataProperties(target, source, excludedItems) {
 		});
 
 		var enumerable = $isEnumerable(from, nextKey) || (
-		// this is to handle string keys being non-enumerable in older engines
+			// this is to handle string keys being non-enumerable in older engines
 			typeof source === 'string'
 			&& nextKey >= 0
 			&& IsInteger(ToNumber(nextKey))

2020/CopyDataProperties.js

@@ -8970,100 +8970,6 @@ var es2020 = function ES2020(ES, ops, expectedMissing, skips) {
 		t.end();
 	});
 
-	test('CopyDataProperties', function (t) {
-		t.test('first argument: target', function (st) {
-			forEach(v.primitives, function (primitive) {
-				st['throws'](
-					function () { ES.CopyDataProperties(primitive, {}, []); },
-					TypeError,
-					debug(primitive) + ' is not an Object'
-				);
-			});
-			st.end();
-		});
-
-		t.test('second argument: source', function (st) {
-			var frozenTarget = Object.freeze ? Object.freeze({}) : {};
-			forEach(v.nullPrimitives, function (nullish) {
-				st.equal(
-					ES.CopyDataProperties(frozenTarget, nullish, []),
-					frozenTarget,
-					debug(nullish) + ' "source" yields identical, unmodified target'
-				);
-			});
-
-			forEach(v.nonNullPrimitives, function (objectCoercible) {
-				var target = {};
-				var result = ES.CopyDataProperties(target, objectCoercible, []);
-				st.equal(result, target, 'result === target');
-				st.deepEqual(keys(result), keys(Object(objectCoercible)), 'target ends up with keys of ' + debug(objectCoercible));
-			});
-
-			st.test('enumerable accessor property', { skip: !$defineProperty }, function (s2t) {
-				var target = {};
-				var source = {};
-				defineProperty(source, 'a', {
-					enumerable: true,
-					get: function () { return 42; }
-				});
-				var result = ES.CopyDataProperties(target, source, []);
-				s2t.equal(result, target, 'result === target');
-				s2t.deepEqual(result, { a: 42 }, 'target ends up with enumerable accessor of source');
-				s2t.end();
-			});
-
-			st.end();
-		});
-
-		t.test('third argument: excludedItems', function (st) {
-			forEach(v.objects.concat(v.primitives), function (nonArray) {
-				st['throws'](
-					function () { ES.CopyDataProperties({}, {}, nonArray); },
-					TypeError,
-					debug(nonArray) + ' is not an Array'
-				);
-			});
-
-			forEach(v.nonPropertyKeys, function (nonPropertyKey) {
-				st['throws'](
-					function () { ES.CopyDataProperties({}, {}, [nonPropertyKey]); },
-					TypeError,
-					debug(nonPropertyKey) + ' is not a Property Key'
-				);
-			});
-
-			var result = ES.CopyDataProperties({}, { a: 1, b: 2, c: 3 }, ['b']);
-			st.deepEqual(keys(result).sort(), ['a', 'c'].sort(), 'excluded string keys are excluded');
-
-			st.test('excluding symbols', { skip: !v.hasSymbols }, function (s2t) {
-				var source = {};
-				forEach(v.symbols, function (symbol) {
-					source[symbol] = true;
-				});
-
-				var includedSymbols = v.symbols.slice(1);
-				var excludedSymbols = v.symbols.slice(0, 1);
-				var target = ES.CopyDataProperties({}, source, excludedSymbols);
-
-				forEach(includedSymbols, function (symbol) {
-					s2t.equal(hasOwn(target, symbol), true, debug(symbol) + ' is included');
-				});
-
-				forEach(excludedSymbols, function (symbol) {
-					s2t.equal(hasOwn(target, symbol), false, debug(symbol) + ' is excluded');
-				});
-
-				s2t.end();
-			});
-
-			st.end();
-		});
-
-		// TODO: CopyDataProperties throws when copying fails
-
-		t.end();
-	});
-
 	test('CreateListFromArrayLike', { skip: !hasBigInts }, function (t) {
 		t.deepEqual(
 			ES.CreateListFromArrayLike({ length: 2, 0: BigInt(1), 1: 'b', 2: 'c' }),