Skip to content

Commit c408c8a

Browse files
committed
[Fix] ES2020+: abs should accept bigints too
Technically it only accepts mathematical values, but JS doesn‘t have those, so it accepts all numerics instead
1 parent 0a25934 commit c408c8a

File tree

12 files changed

+16
-17
lines changed

12 files changed

+16
-17
lines changed

.gitattributes

-1
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,6 @@
731731
/2020/WeekDay.js spackled linguist-generated=true
732732
/2020/WordCharacters.js spackled linguist-generated=true
733733
/2020/YearFromTime.js spackled linguist-generated=true
734-
/2020/abs.js spackled linguist-generated=true
735734
/2020/max.js spackled linguist-generated=true
736735
/2020/min.js spackled linguist-generated=true
737736
/2020/modulo.js spackled linguist-generated=true

2015/abs.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2016/abs.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2017/abs.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2018/abs.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2019/abs.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2020/abs.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
var $abs = require('math-intrinsics/abs');
44

5-
// http://262.ecma-international.org/5.1/#sec-5.2
5+
// https://262.ecma-international.org/11.0/#eqn-abs
66

77
module.exports = function abs(x) {
8-
return $abs(x);
8+
return typeof x === 'bigint' ? BigInt($abs(Number(x))) : $abs(x);
99
};

2021/abs.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2022/abs.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2023/abs.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

2024/abs.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

5/abs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
var $abs = require('math-intrinsics/abs');
44

5-
// http://262.ecma-international.org/5.1/#sec-5.2
5+
// https://262.ecma-international.org/5.1/#sec-5.2
66

77
module.exports = function abs(x) {
88
return $abs(x);

0 commit comments

Comments
 (0)