Skip to content

Rename the PodMetrics type #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahg-g opened this issue Feb 18, 2025 · 5 comments
Open

Rename the PodMetrics type #360

ahg-g opened this issue Feb 18, 2025 · 5 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 18, 2025

Perhaps we can name it Endpoint

@kfswain
Copy link
Collaborator

kfswain commented Feb 19, 2025

I like ModelServerPod and then Metrics as a field of the struct. But I feel more strongly that we move away from PodMetrics than I do towards a specific name (so long as that name is an improvement.)

Let the Great Name Wars commence! 😆

@kfswain kfswain added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 19, 2025
@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 19, 2025

Nit: in a multi-node setup, the server is not just a pod, it is a group of pods. While we could say that we only care about the single pod representing the group (aka the leader), an endpoint might be more generic here especially if we name the extension "Endpoint Picker".

@hzxuzhonghu
Copy link
Member

hzxuzhonghu commented Feb 21, 2025

The InferencePoolSpec.Selector documented to select model server pods, so how about ModelServerStats

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 21, 2025

ModelServer alone is another one?

I generally think this item is lower priority compared to increasing test coverage though.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants