Skip to content

Improve metric capture on error #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kfswain opened this issue Mar 20, 2025 · 2 comments
Open

Improve metric capture on error #554

kfswain opened this issue Mar 20, 2025 · 2 comments
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kfswain
Copy link
Collaborator

kfswain commented Mar 20, 2025

Our metrics currently capture errors and associate them with an inferenceModel and targetModel:

func RecordRequestErrCounter(modelName, targetModelName string, code string) {

We should also include the endpoint that the error is affiliated with to better catch faulty pods/nodes.

Additionally errors such as ERR_CONNECTION_REFUSED don't have an explicit error code. The deferred error capture here:

likely covers this. But would be good to validate manually & with test cases. (I didn't see a test case from a brief search of the repo)

@JeffLuoo
Copy link
Contributor

Do you have any examples of triggering errors without an explicit error code like ERR_CONNECTION_REFUSED ?

@kfswain
Copy link
Collaborator Author

kfswain commented Apr 22, 2025

I don't quite remember when I hit that, I think it was load testing.

We can scope this issue to just capturing the endpoint on error

@kfswain kfswain added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants