Skip to content

Commit 37e5386

Browse files
committed
5018-update namespace label
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
1 parent 7c44305 commit 37e5386

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

keps/sig-auth/5018-dra-adminaccess/README.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ objects as privileged. This feature includes:
179179
```yaml
180180
metadata:
181181
labels:
182-
kubernetes.io/dra-admin-access: "true"
182+
resource.k8s.io/admin-access: "true"
183183
```
184184
185185
Assumptions:
@@ -194,7 +194,7 @@ objects as privileged. This feature includes:
194194
195195
In the REST storage layer, validate requests to create and update
196196
`ResourceClaim` or `ResourceClaimTemplate` objects with `adminAccess: true`.
197-
Only authorize if namespace has the `kubernetes.io/dra-admin-access` label.
197+
Only authorize if namespace has the `resource.k8s.io/admin-access: "true"` label.
198198
199199
1. Grants privileged access to the requested device:
200200
@@ -212,7 +212,7 @@ objects as privileged. This feature includes:
212212
### Workflow
213213

214214
1. A cluster administrator labels an admin namespace with
215-
`kubernetes.io/dra-admin-access`.
215+
`resource.k8s.io/admin-access: "true"`.
216216
217217
1. Users who are authorized to create `ResourceClaim` or `ResourceClaimTemplate`
218218
objects in this admin namespace can set `adminAccess: true` field if they
@@ -284,7 +284,7 @@ shouldn't have allowed unrestricted access.
284284
Starting in Kubernetes 1.33 (when this KEP was introduced), a validation has
285285
been added to the REST storage layer to only authorize `ResourceClaim` or
286286
`ResourceClaimTemplate` with `adminAccess: true` requests if their namespace has
287-
the `kubernetes.io/dra-admin-access` label to only allow it for users with
287+
the `resource.k8s.io/admin-access: "true"` label to only allow it for users with
288288
additional privileges.
289289
290290
The below flowchart starts with `ResourceClaim` creation from
@@ -401,7 +401,7 @@ https://storage.googleapis.com/k8s-triage/index.html
401401

402402
The scheduler plugin and resource claim controller are covered by the workloads
403403
in
404-
https://github.com/kubernetes/kubernetes/blob/master/test/test/integration/scheduler_perf/dra/performance-config.yaml
404+
https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler_perf/dra/performance-config.yaml
405405

406406
Those tests run in:
407407

@@ -415,7 +415,7 @@ Those tests run in:
415415
- Additional test cases will be added to `test/integration/scheduler_perf` to
416416
ensure `ResourceClaim` or `ResourceClaimTemplate` with `adminAccess: true`
417417
requests are only authorized if their namespace has the
418-
`kubernetes.io/dra-admin-access` label as described in this KEP.
418+
`resource.k8s.io/admin-access: "true"` label as described in this KEP.
419419
420420
##### e2e tests
421421
@@ -436,7 +436,7 @@ was developed as part of the overall DRA development effort. We have extended
436436
this test driver to enable `DRAAdminAccess` feature gate and added tests to
437437
ensure `ResourceClaim` or `ResourceClaimTemplate` with `adminAccess: true`
438438
requests are only authorized if their namespace has the
439-
`kubernetes.io/dra-admin-access` label as described in this KEP.
439+
`resource.k8s.io/admin-access: "true"` label as described in this KEP.
440440
441441
Test links:
442442

0 commit comments

Comments
 (0)