Skip to content

Commit f7b52ac

Browse files
committed
Clarify which API versions are impacted by the change.
1 parent f3fa3a1 commit f7b52ac

File tree

1 file changed

+6
-3
lines changed
  • keps/sig-autoscaling/4951-configurable-hpa-tolerance

1 file changed

+6
-3
lines changed

keps/sig-autoscaling/4951-configurable-hpa-tolerance/README.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -260,15 +260,18 @@ It will be replaced by:
260260
+ if (1.0-downTolerance) <= usageRatio && usageRatio <= (1.0+upTolerance) { /* ... */ }
261261
```
262262

263-
Since the added field is optional and it's omission results in no change to the existing
264-
autoscaling behavior, this feature can be added to the current API
265-
version `pkg/apis/autoscaling/v2`.
263+
Since the added field is optional and its omission does not change the existing
264+
autoscaling behavior, this feature will only be added to the latest stable API
265+
version `pkg/apis/autoscaling/v2`. Older versions (i.e. `v1`, `v2beta1`,
266+
`v2beta2`) will not include the new field, but converters will be updated where
267+
needed to comply with [round-trip requirements][].
266268

267269
The feature presented in this KEP only allows users to tune an existing parameter, and
268270
as such doesn't require any new HPA Events or modify any Status. The validation logic
269271
will be updated to ensure that the `tolerance` field cannot be set to a negative value.
270272

271273
[replica_calculator.go]: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/podautoscaler/replica_calculator.go
274+
[round-trip requirements]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecating-parts-of-the-api
272275

273276
### Test Plan
274277

0 commit comments

Comments
 (0)