Skip to content

All telemetry criteria bug #8084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: gold
Choose a base branch
from
Draft

All telemetry criteria bug #8084

wants to merge 4 commits into from

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented May 30, 2025

Closes VIPERGC-816

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes? Will add an openmct-yamcs e2e test when that repository is no longer broken
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@akhenry akhenry changed the base branch from master to gold May 30, 2025 16:15
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (gold@4aea6a5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ugins/condition/criterion/AllTelemetryCriterion.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             gold    #8084   +/-   ##
=======================================
  Coverage        ?   62.89%           
=======================================
  Files           ?      436           
  Lines           ?    13700           
  Branches        ?        0           
=======================================
  Hits            ?     8616           
  Misses          ?     5084           
  Partials        ?        0           
Flag Coverage Δ
e2e-ci 62.80% <75.00%> (?)
e2e-full 23.59% <0.00%> (?)
Files with missing lines Coverage Δ
.../plugins/condition/criterion/TelemetryCriterion.js 78.94% <100.00%> (ø)
...ugins/condition/criterion/AllTelemetryCriterion.js 26.01% <66.66%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea6a5...6dd3bfc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const validatedData = this.isValid()
? this.createNormalizedDatum(data, this.telemetryObject)
: {};
const validatedData = this.isValid() ? data : {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Because it's already normalized in ConditionManager. Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants