Marcus Bains "ahead/behind" for #8091 #8094
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent-visualization
- Removed in-page `style` defs from ExtendedLinesOverlay.vue; CSS actually located in timeline.scss.
- Improved sizing and style for Marcus Bains ("now") line.
- Removed extraneous padding at bottom of plot view when in Time Strip.
- Added missing header info to timeline.scss.
- CSS refinements.
- Removed bad `}` in TimeSystemAxis.vue. - Removed `.u-contents` from line 129 of ganttChart.e2e.spec.js. - Removed `event-handle` element; not needed. - Changed `__event-wrapper` to not set height explicitly; uses absolute positioning. - Added :before element to event-wrapper for better hit area. - Improved hover styling. - $colorEvent* style constants added to theme constant SCSS files.
- Layout converted to set `min-height` on top-most `c-swimlane` element. Interior containers now use 100% height or absolute positioning. - Removed `c-timeline-holder` from `c-events-tsv` in EventTimelineView.vue; Refactored `c-events-tsv__contents` to be `js-events-tsv` as that was being used as a reference. - New theme constant `eventLineW` sets event lines to be 1px wide for more precision.
…d-discrete-event-visualization
…adjustable-swimlane-size
…adjustable-swimlane-size
…send tick updates
…adjustable-swimlane-size
- Reduced opacity of extended event lines and the Marcus-Baines line to not obfuscate telemetry and other data displayed in the Time Strip. - Removed commented CSS code.
- Reduced opacity of extended event lines and the Marcus-Baines line to not obfuscate telemetry and other data displayed in the Time Strip. - Removed commented CSS code. - WIP!
allow for fixed containers WIP move existing functionality into setup
…ize' into issue/7957-adjustable-swimlane-size
- Now normalizes margin so that main-container does not change size between browse and edit modes. - Fixed long-standing regression where extra space was added for the toolbar when editing, even if view does not use a toolbar.
… Strip view. - TimelineViewLayout.vue now adds `is-object-type-*` to its container to allow CSS selection. - Object's `c-object-view` handles overflow-y with scroll when in Time Strip. This is necessary to prevent scrolling of the left hand labels and maintain a consistent right edge alignment for time sync purposes. - Fixed long-standing regression where extra space was added for the toolbar when editing, even if view does not use a toolbar. - Main view now uses dashed border instead of box-shadow for `.is-editing`; theme constants removed.
add swimLaneLabelWidth input to inspector
- New theme constants for ahead and behind colors. - Mods to c-timesystem-axis element to hide domain line. - New Vue properties. - Clipping wrapper for MB and AB lines. - Applied `white-space: nowrap` to elements that needed it. - TODO: figure out why contentHeight isn't working right in this branch.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8094 +/- ##
==========================================
- Coverage 57.63% 55.16% -2.47%
==========================================
Files 678 693 +15
Lines 27440 28034 +594
Branches 2694 2747 +53
==========================================
- Hits 15816 15466 -350
- Misses 11282 12222 +940
- Partials 342 346 +4
... and 53 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
charlesh88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8091
IMPORTANT!!! Forked from
issue/7957-adjustable-swimlane-sizebranch.Describe your changes:
white-space: nowrapto elements that needed it.TODO:
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist