-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Expanded Time List enhancements for #8091 #8095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Significant markup and CSS changes. - Activities now use Plan colors. - Greatly improved narrow space and wrapping. - WIP! - Todos: status icons, revised past/current/future styling.
- Status icons WIP. - Todos: Revised past/current/future styling.
- Added new global data uri's for status icons. - Added new global `gear-spinner` animation for in-progress Activity status icon. - Added new global `absCenter` mixin. - Revised and greatly simplified execution status and time context labels. - Still WIP. Todos: - Revised past/current/future styling. - Status icon coloring move to theme constants.
- Revised past/current/future styling. - Still WIP. Todos: - Status icon coloring move to theme constants. - Update other themes constants for new approach to bg/fg/em.
- Revised, refined past/current/future styling and theme colors. - Status icon coloring added to theme constants. - Updated other themes constants for new approach to bg/fg/em. - Smoke tested in Espresso and Snow themes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8095 +/- ##
==========================================
- Coverage 57.68% 57.34% -0.34%
==========================================
Files 684 684
Lines 27558 27546 -12
Branches 2700 2695 -5
==========================================
- Hits 15897 15797 -100
- Misses 11326 11411 +85
- Partials 335 338 +3
... and 20 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
(Partially) closes #8091 - this is the Time List part of that issue.
This should be looked over by a developer for functional issues. For example, how I implemented the Plan colors - there is probably a more resource-efficient way that could be done.
Describe your changes:
gear-spinner
animation for in-progress Activity status icon.absCenter
mixin.All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist