Skip to content

Expanded Time List enhancements for #8091 #8095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Jun 12, 2025

(Partially) closes #8091 - this is the Time List part of that issue.

This should be looked over by a developer for functional issues. For example, how I implemented the Plan colors - there is probably a more resource-efficient way that could be done.

Describe your changes:

  • Significant markup and CSS changes.
  • Revised and greatly simplified execution status and time context labels.
  • Activities now use Plan colors.
  • Greatly improved layout and wrapping for narrow spaces.
  • Added new global data uri's for status icons.
  • Added new global 6 step gear-spinner animation for in-progress Activity status icon.
  • Added new global absCenter mixin.
  • Revised, refined past/current/future styling and theme colors.
  • Status icon coloring added to theme constants.
  • Updated other themes constants for new approach to bg/fg/em.
  • Smoke tested in Espresso and Snow themes.

Screenshot 2025-06-11 at 10 08 15 PM
Screenshot 2025-06-11 at 10 07 05 PM
Screenshot 2025-06-11 at 10 13 35 PM

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

- Significant markup and CSS changes.
- Activities now use Plan colors.
- Greatly improved narrow space and wrapping.
- WIP!
- Todos: status icons, revised past/current/future styling.
- Status icons WIP.
- Todos: Revised past/current/future styling.
- Added new global data uri's for status icons.
- Added new global `gear-spinner` animation for in-progress Activity status icon.
- Added new global `absCenter` mixin.
- Revised and greatly simplified execution status and time context labels.
- Still WIP. Todos:
  - Revised past/current/future styling.
  - Status icon coloring move to theme constants.
- Revised past/current/future styling.
- Still WIP. Todos:
  - Status icon coloring move to theme constants.
  - Update other themes constants for new approach to bg/fg/em.
- Revised, refined past/current/future styling and theme colors.
- Status icon coloring added to theme constants.
- Updated other themes constants for new approach to bg/fg/em.
- Smoke tested in Espresso and Snow themes.
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 57.34%. Comparing base (826c713) to head (2d2d41e).

Files with missing lines Patch % Lines
src/plugins/timelist/ExpandedViewItem.vue 5.26% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8095      +/-   ##
==========================================
- Coverage   57.68%   57.34%   -0.34%     
==========================================
  Files         684      684              
  Lines       27558    27546      -12     
  Branches     2700     2695       -5     
==========================================
- Hits        15897    15797     -100     
- Misses      11326    11411      +85     
- Partials      335      338       +3     
Flag Coverage Δ
e2e-ci 62.09% <ø> (-1.12%) ⬇️
e2e-full 42.89% <ø> (-0.08%) ⬇️
unit 49.09% <5.26%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
src/plugins/timelist/TimelistComponent.vue 64.79% <ø> (ø)
src/plugins/timelist/ExpandedViewItem.vue 5.76% <5.26%> (+1.08%) ⬆️

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826c713...2d2d41e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marcus Bains "ahead/behind" line and Expanded Activities enhancements
1 participant