Skip to content

test: refactor instrumentation/redis tests #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zvkemp opened this issue Jan 30, 2025 · 1 comment
Open

test: refactor instrumentation/redis tests #1382

zvkemp opened this issue Jan 30, 2025 · 1 comment
Labels
keep Ensures stale-bot keeps this issue/PR open

Comments

@zvkemp
Copy link
Contributor

zvkemp commented Jan 30, 2025

As discovered in #1370, the arrangement of redis tests is prone to mistakes — they are grouped perhaps correctly as unit tests, however, the implementation of the target libraries makes this complicated:

  • redis (~> 4): uses the RedisV4Client patches
  • redis-client: uses the RedisClient middleware instrumentation
  • redis (~> 5): a wrapper around RedisClient; uses the RedisClient middleware(s).

In most cases, the actions and expectations should be the same (but there are some edge cases). It may be worthwhile to group the tests based on their target gem rather than the instrumentation used.

Copy link
Contributor

github-actions bot commented Mar 2, 2025

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Mar 2, 2025
@kaylareopelle kaylareopelle added keep Ensures stale-bot keeps this issue/PR open and removed stale Marks an issue/PR stale labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Ensures stale-bot keeps this issue/PR open
Projects
None yet
Development

No branches or pull requests

2 participants