Skip to content

fix(ola-nics): fixing the display of the list of nics #17699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

aderghamov
Copy link
Contributor

ref: #MANAGER-17094

Description

This PR fixes the issues that has been detected when qualifying the rework of the network interface tile:

  • properly displaying bandwidths, IP, additionnal IP and private network columns
  • removing the useless pagination of the table
  • displaying a blank network interface name when the interface has no virtual network

Ticket Reference: #MANAGER-17094

Additional Information

@aderghamov aderghamov requested review from a team as code owners June 18, 2025 13:29
@aderghamov aderghamov requested review from qpavy, chipp972, mhelhali-soufien, tibs245, darsene and sefiani-ovh and removed request for a team June 18, 2025 13:29
@github-actions github-actions bot added the bug Something isn't working label Jun 18, 2025
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 19, 2025
ref: #MANAGER-17094

Signed-off-by: aderghamov <alexandre.dergham.ext@ovhcloud.com>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jun 19, 2025
@aderghamov aderghamov requested a review from qpavy June 19, 2025 15:10
@aderghamov aderghamov merged commit 3783c5f into project/ola-redesign Jun 19, 2025
12 of 13 checks passed
@aderghamov aderghamov deleted the fix/MANAGER-17094 branch June 19, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants