Skip to content

feat(core-api): add ovh api typguard #17718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(core-api): add ovh api typguard #17718

wants to merge 2 commits into from
+142 −1

Conversation

lionel95200x
Copy link
Contributor

Description

  • Add type safe helper for ovh api error

Ticket Reference: #...

Additional Information

@lionel95200x lionel95200x requested a review from a team as a code owner June 19, 2025 10:15
@github-actions github-actions bot added common feature New feature labels Jun 19, 2025
@lionel95200x lionel95200x force-pushed the feat/add-api-typeguard branch from e8bd333 to 831ed72 Compare June 19, 2025 11:55
@lionel95200x
feat(core-api): add ovh api typguard
e7de36c 
Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>
@lionel95200x lionel95200x force-pushed the feat/add-api-typeguard branch from 831ed72 to e7de36c Compare June 19, 2025 12:49
@fredericvilcot fredericvilcot marked this pull request as draft June 19, 2025 13:06
@fredericvilcot fredericvilcot force-pushed the feat/add-api-typeguard branch from 07f0ee7 to d4884dd Compare June 19, 2025 13:46
@fredericvilcot
feat(core-api): enhance folder architecture
886bf34 
Signed-off-by: Frédéric Vilcot <fredericvilcot@gmail.com>
@fredericvilcot fredericvilcot force-pushed the feat/add-api-typeguard branch from d4884dd to 886bf34 Compare June 19, 2025 13:56
@lionel95200x lionel95200x marked this pull request as ready for review June 19, 2025 14:27
SimonChaumet
SimonChaumet previously approved these changes Jun 19, 2025
View reviewed changes
fredericvilcot
fredericvilcot previously approved these changes Jun 19, 2025
View reviewed changes
@lionel95200x lionel95200x changed the base branch from master to develop June 19, 2025 15:37
@lionel95200x lionel95200x dismissed stale reviews from fredericvilcot and SimonChaumet June 19, 2025 15:37

The base branch was changed.

@fredericvilcot fredericvilcot self-requested a review June 19, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@helabenkhalfallah helabenkhalfallah Awaiting requested review from helabenkhalfallah helabenkhalfallah is a code owner automatically assigned from ovh/dev-manager-control-tower

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud Awaiting requested review from aboungnaseng-ovhcloud aboungnaseng-ovhcloud is a code owner automatically assigned from ovh/dev-manager-control-tower

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
common feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionel95200x @SimonChaumet @fredericvilcot