fix(manager-pci-common): add undefined type to the project on isDisco… #17728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veryProject ref: #17727 Signed-off-by: LIDRISSI Hamid <lidrissi.hamid@gmail.com>
1 task
| @@ -11,7 +11,7 @@ import '../../../translations/discovery-banner'; | |||
|
|
|||
| const DISCOVERY_PROJECT_PLAN_CODE = 'project.discovery'; | |||
|
|
|||
| export const isDiscoveryProject = (project: TProject) => | |||
| export const isDiscoveryProject = (project: TProject | undefined) => | |||
There was a problem hiding this comment.
Suggested change
| export const isDiscoveryProject = (project: TProject | undefined) => | |
| export const isDiscoveryProject = (project?: TProject) => |
There was a problem hiding this comment.
Is the same idea no ?
There was a problem hiding this comment.
Yes, but the first one is verbose regarding how TS defines optional parameters (https://www.typescriptlang.org/docs/handbook/2/functions.html#optional-parameters)
it's up to you as of course it's non blocking ;)
| @@ -11,7 +11,7 @@ import '../../../translations/discovery-banner'; | |||
|
|
|||
| const DISCOVERY_PROJECT_PLAN_CODE = 'project.discovery'; | |||
|
|
|||
| export const isDiscoveryProject = (project: TProject) => | |||
| export const isDiscoveryProject = (project: TProject | undefined) => | |||
There was a problem hiding this comment.
For me we should not have an undefined project at this step. You should catch errors at the top app level, and throughout your entire app consider that the project exists.
Because with this implementation we check multiple times in each banner and screen if a project exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…veryProject
ref: #17727