Skip to content

Conversation

@danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Nov 10, 2023

Main changes

  • bump pa11y-ci to 4 from 2
  • use Node 20 up from 8
  • use Ruby 3 up from 2 and update some deps
  • describe how to install Ruby and Node stuff and to validate/test workflows locally
  • some tidying up
    • use Pa11y's .editorconfig
    • gently forbid asdf because it caused me some trouble a while back here
    • add command make browse (jekyll serve --open is available but adding --open it would interfere with build and it can't be run again without restarting server)
    • build badge

@danyalaytekin danyalaytekin self-assigned this Nov 10, 2023
@danyalaytekin danyalaytekin marked this pull request as ready for review November 10, 2023 11:07
@jpw
Copy link

jpw commented Nov 10, 2023

I know nothing about Ruby so unable to assist with reviewing this one sadly.

Copy link
Member

@hollsk hollsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT to me, thanks @danyalaytekin 🙏

@sonniesedge
Copy link
Contributor

What idiot asked me to review something? 😂

@sonniesedge
Copy link
Contributor

What idiot asked me to review something? 😂

Oh hai @danyalaytekin 😂

@danyalaytekin danyalaytekin added the dependencies Pull requests that update a dependency file label Mar 18, 2024
@danyalaytekin danyalaytekin changed the title Upgrade dependencies, including pa11y-ci to 3 from 2 Upgrade dependencies, including pa11y-ci to 4 from 2 Oct 24, 2025
@danyalaytekin
Copy link
Member Author

Thanks for your earlier 2023 approval @hollsk! pa11y-ci has moved on again, so I've updated its version and made a few other tweaks to allow the project to build and pass its tests. I'll merge this now but let me know if there's any additional feedback. P.S. The CC image on the homepage appears to have gone missing - I haven't fixed this here.

@danyalaytekin danyalaytekin merged commit 8284212 into main Oct 24, 2025
5 checks passed
@danyalaytekin danyalaytekin deleted the upgrade branch October 24, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants