Pyright job is flaky and temporarily optional

[hynek]

Presumably due to some hosting changes, nodeenv and by extension Pyright are regularly failing now.

I've marked it as optional for now, but would like to re-activate it ASAP.

Ref ekalinin/nodeenv#324

[webknjaz]

Instead of commenting out the job dependency, you can use an action input to mark when it's okay for a job to fail FYI

[hynek]

If you wanna open a PR, feel free. For me that was easier than reading docs. ..🤪

[hynek]

Looks like pyright is now really breaking as of presumably 1.1.309:

E         Full diff:
E           {
E         +  PyrightDiagnostic(severity='error', message='Cannot assign member "a" for type "Frozen"\n\xa0\xa0"Frozen" is frozen'),
E         +  PyrightDiagnostic(severity='information', message='Type of "DefineConverter.__init__" is "(self: DefineConverter, with_converter: int) -> None"'),
E         +  PyrightDiagnostic(severity='information', message='Type of "Define.__init__" is "(self: Define, a: str, b: int) -> None"'),
E         +  PyrightDiagnostic(severity='error', message='Cannot assign member "a" for type "FrozenDefine"\n\xa0\xa0"FrozenDefine" is frozen'),
E         +  PyrightDiagnostic(severity='information', message='Type of "af.__init__" is "(_a: int) -> None"'),
E            PyrightDiagnostic(severity='information', message='Type of "d2.a" is "Literal[\'new\']"'),
E         -  PyrightDiagnostic(severity='information', message='Type of "af.__init__" is "(_a: int) -> None"'),
E         -  PyrightDiagnostic(severity='error', message='Cannot assign member "a" for type "FrozenDefine"\n\xa0\xa0"FrozenDefine" is frozen'),
E         -  PyrightDiagnostic(severity='error', message='Cannot assign member "a" for type "Frozen"\n\xa0\xa0"Frozen" is frozen'),
E         -  PyrightDiagnostic(severity='information', message='Type of "Define.__init__" is "(self: Define, a: str, b: int) -> None"'),
E         -  PyrightDiagnostic(severity='information', message='Type of "DefineConverter.__init__" is "(self: DefineConverter, with_converter: str | bytes | bytearray | memoryview | array[Any] | mmap | _CData | PickleBuffer | SupportsInt | SupportsIndex | SupportsTrunc) -> None"'),
E            PyrightDiagnostic(severity='information', message='Type of "d.a" is "Literal[\'new\']"'),
E           }

tests/test_pyright.py:85: AssertionError

Volunteers? 😇🤓