Skip to content

Remove "enableExperimentalFeatures = true" from pyright config #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erictraut opened this issue Sep 1, 2024 · 1 comment
Closed

Remove "enableExperimentalFeatures = true" from pyright config #1341

erictraut opened this issue Sep 1, 2024 · 1 comment

Comments

@erictraut
Copy link
Contributor

I noticed that the pyproject.toml used in attrs contains the following:

[tool.pyright]
# We need epexrimental features for converters.
enableExperimentalFeatures = true

This comment was previously true, but this is no longer necessary. Now that the converters functionality is officially incorporated into the typing spec, it is no longer considered experimental. All versions of pyright from 1.1.373 onward support this functionality without setting the "enableExperimentalFeatures" flag to true.

I noticed that this configuration flag was enabled because I'm implementing some new experimental features in pyright, and the regression tests that I run on attrs triggered usage of the new experimental feature.

@hynek hynek closed this as completed in 64ff5a9 Sep 2, 2024
@hynek
Copy link
Member

hynek commented Sep 2, 2024

thanks for letting us know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants