You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A user might want to use attributes from an already @defined class to populate a new attrs class. However, _ClassBuilder expects all given attributes to be instances of _CountingAttr instead of Attribute instances, which raises an exception when provided:
importattrs@attrs.defineclassExample:
a: intExampleCopy=attrs.make_class("ExampleCopy", attrs={"a": attrs.fields(Example).a})
# AttributeError: 'Attribute' object has no attribute '_validator'. Did you mean: 'validator'?@attrs.define(these={"a": attrs.fields(Example).a})classExampleCopy:
pass# AttributeError: 'Attribute' object has no attribute '_validator'. Did you mean: 'validator'?
I would either expect _ClassBuilder to handle both kinds of attributes, or there be an officially sanctioned function allowing you to convert an Attribute to a _CountingAttr for cases like this. You can write this conversion function manually, something like:
defconvert_to_countingattr(attr):
""" Convert an `Attribute` instance to an equivalent `_CountingAttr` instance. """returnattrs.field(**{
slot: getattr(attr, slot)
forslotinattr.__slots__ifslotnotin {"name", "eq_key", "order_key", "inherited"}
})
But this feels janky and prone to breakage.
The text was updated successfully, but these errors were encountered:
This seems related to #637; the proposed to_field() method would make this trivial.
The utility of this behavior is that it would make it much easier to manipulate the user class before it is passed to attrs plumbing, so you could do things like custom attribute ordering or similar.
A user might want to use attributes from an already
@define
d class to populate a new attrs class. However,_ClassBuilder
expects all given attributes to be instances of_CountingAttr
instead ofAttribute
instances, which raises an exception when provided:I would either expect
_ClassBuilder
to handle both kinds of attributes, or there be an officially sanctioned function allowing you to convert anAttribute
to a_CountingAttr
for cases like this. You can write this conversion function manually, something like:But this feels janky and prone to breakage.
The text was updated successfully, but these errors were encountered: