add attr docstring #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #74 diff @@
===================================
Files 8 8
Lines 395 396 +1
Methods 0 0
Messages 0 0
Branches 87 87
===================================
+ Hits 395 396 +1
Misses 0 0
Partials 0 0
|
|
Are supported versions clearly written anywhere? I see "rigorously tested on Python 2.7, 3.4+, and PyPy" in the readme -- does this imply 2.6/3.3 are not supported, or might work but not tested (with unannounced breakage, ...)? |
|
Correct, 2.6 and 3.3 are not supported: https://github.com/hynek/attrs/blob/master/CHANGELOG.rst#1600-2016-05-23 We don't test on them so I have no idea if they will work or not (3.3 will probably work), and if they don't work we basically don't care. |
|
Heh I can stress as much as I want that small contributions are welcome and people will still apologize for them. :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated docstring merely points to the docs elsewhere. I started with "{} <{}>".format, but I'm new to attrs and wasn't sure if that meets the requirement for all supported Python versions.