Skip to content

Add hooks for zoneinfo.ZoneInfo #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
makukha opened this issue Mar 29, 2025 · 2 comments
Closed

Add hooks for zoneinfo.ZoneInfo #640

makukha opened this issue Mar 29, 2025 · 2 comments

Comments

@makukha
Copy link

makukha commented Mar 29, 2025

Many thanks to authors of cattrs for the minimalistic design and simplicity!

Do you think it is reasonable to add more hooks, covering frequently used classes from stdlib?
In this specific case I mean zoneinfo.ZoneInfo, both structuring and unstructuring.

I probably could come up with PR for this.

@Tinche
Copy link
Member

Tinche commented Mar 29, 2025

Hi,

Thanks for the offer. The problem with adding these less commonly used types is that they add a tiny bit of overhead to converter startup, and possibly the import time, and this has to be borne by everyone.

What we could do is add a section to the recipes doc with hooks for these stdlib types. I'd merge that in no problem.

Going to close this now in an attempt to keep the issue list manageable. 😇

@Tinche Tinche closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2025
@makukha
Copy link
Author

makukha commented Mar 29, 2025

Got it, this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants