Add a fourth fuzzer for injecting comments #2822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fuzz-dollar #2822 +/- ##
============================================
Coverage 99.27% 99.28%
============================================
Files 128 128
Lines 7183 7246 +63
============================================
+ Hits 7131 7194 +63
Misses 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 10, 2025
|
This diff is rather large. Could you break it up into a few bug fix PRs and a final fuzzer PR? |
This was referenced Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2191 -- continuing #2821 (which is included here & against which this is based, for now). Also progress on #2737.
Closes #2824. Closes #2825. Closes #2826. Closes #2827.
Wow, this one really spiralled out of control & became quite a quixotic endeavor in the end.
A lot of it is really edge-casey, but better to have the fix than not. A surprising number of legit issues / bugs (i.e. not false positive/negative, but {lintr} errors based on faulty assumptions).
Probably, some pieces of this belong in dedicated PRs separate from this one.
Filing for now to get things started.