-
Notifications
You must be signed in to change notification settings - Fork 193
Add grepv() awareness to the package #2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 127 127
Lines 7078 7080 +2
=======================================
+ Hits 7053 7055 +2
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially in a follow up PR, but if we start recommending grepv()
(which I agree with), it would be good to also lint grep(, value = TRUE)
.
Yea, I've been meaning to file that as an issue for a new linter (presumably |
Also fixes #2648 I think. |
Closes #2855. Closes #2648. Progress on #2737