Skip to content

Conversation

MichaelChirico
Copy link
Collaborator

@MichaelChirico MichaelChirico commented May 7, 2025

Closes #2855. Closes #2648. Progress on #2737

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (b9c4205) to head (5792122).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2856   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         127      127           
  Lines        7078     7080    +2     
=======================================
+ Hits         7053     7055    +2     
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IndrajeetPatil IndrajeetPatil requested a review from Bisaloo May 18, 2025 12:47
Copy link
Collaborator

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially in a follow up PR, but if we start recommending grepv() (which I agree with), it would be good to also lint grep(, value = TRUE).

@MichaelChirico
Copy link
Collaborator Author

Potentially in a follow up PR, but if we start recommending grepv() (which I agree with), it would be good to also lint grep(, value = TRUE).

Yea, I've been meaning to file that as an issue for a new linter (presumably grepv_linter(), I'm not sure if maybe it should be subsumed in another linter, probably not).

@Bisaloo
Copy link
Collaborator

Bisaloo commented Jun 5, 2025

Also fixes #2648 I think.

@MichaelChirico MichaelChirico merged commit 56c3c6d into main Jun 24, 2025
20 checks passed
@MichaelChirico MichaelChirico deleted the gre branch June 24, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lintr is not grepv-aware Reference new grepv() in regex_subset_linter() once it makes an R release
2 participants