-
Notifications
You must be signed in to change notification settings - Fork 193
add gitlab_output()
: a report format digestible by gitlab
#2862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gitlab_output()
: a report format digestible by gitlab
#2862
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 127 127
Lines 7080 7109 +29
=======================================
+ Hits 7055 7084 +29
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@MichaelChirico I would appreciate your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level LGTM. I'll take your word for it that the integration is WAI.
I do wonder if maybe we should be extending print()
instead (or in addition to?) adding new exports, e.g. print(output = "gitlab")
, print(output = "sarif")
, etc. But that's an issue for another day I think.
Please add a NEWS entry.
…change `digest::sha1()` to `digest::digest()`.
I plan to use that feature quite regularily within our CI pipeline. In case any broken edge cases come up, I will submit a fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Addresses #2858.
I tested on gitlab whether gitlab compains about the format by pushing a locally generated report: https://gitlab.com/lschneiderbauer-group/lintr-test/-/merge_requests/1

It seems to work fine: