Skip to content

Conversation

lschneiderbauer
Copy link
Contributor

@lschneiderbauer lschneiderbauer commented Jun 7, 2025

Addresses #2858.

I tested on gitlab whether gitlab compains about the format by pushing a locally generated report: https://gitlab.com/lschneiderbauer-group/lintr-test/-/merge_requests/1
It seems to work fine:
image

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (56c3c6d) to head (9b7e2c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2862   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         127      127           
  Lines        7080     7109   +29     
=======================================
+ Hits         7055     7084   +29     
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lschneiderbauer
Copy link
Contributor Author

@MichaelChirico I would appreciate your feedback.

Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level LGTM. I'll take your word for it that the integration is WAI.

I do wonder if maybe we should be extending print() instead (or in addition to?) adding new exports, e.g. print(output = "gitlab"), print(output = "sarif"), etc. But that's an issue for another day I think.

Please add a NEWS entry.

@lschneiderbauer
Copy link
Contributor Author

lschneiderbauer commented Jun 10, 2025

I'll take your word for it that the integration is WAI.

I plan to use that feature quite regularily within our CI pipeline. In case any broken edge cases come up, I will submit a fix.

Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@MichaelChirico MichaelChirico merged commit 3539ef4 into r-lib:main Jun 25, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants