feat: support printing of datetime without seconds #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. Is this a snapshot test that needs updating? The "simple" shaft may work here, but should we perhaps use adaptive rendering (https://vctrs.r-lib.org/articles/pillar.html#adaptive-rendering) to support a larger variety of patterns? |
Contributor
Author
|
Tried your suggestion, but now the NA don't show as red. And I can't get it to print the seconds in any way now... With a very wide console: (Even though it passes checks, it is likely incorrect) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem to work for now, but opening for discussion
Addresses #647
1st version
Seems to work, but the tests don't work.
Current commit never shows seconds