-
Notifications
You must be signed in to change notification settings - Fork 234
DOC-5282 RDI: restructure config/job file details #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language LGTM. Well, that was a full day's work. See ya tomorrow. 😂
Thanks @dwdougherty ! Yeah, see you tomorrow ;-) |
content/integrate/redis-data-integration/data-pipelines/pipeline-config.md
Show resolved
Hide resolved
content/integrate/redis-data-integration/data-pipelines/transform-examples/_index.md
Outdated
Show resolved
Hide resolved
content/integrate/redis-data-integration/data-pipelines/transform-examples/_index.md
Outdated
Show resolved
Hide resolved
content/integrate/redis-data-integration/data-pipelines/transform-examples/_index.md
Outdated
Show resolved
Hide resolved
content/integrate/redis-data-integration/data-pipelines/transform-examples/_index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Zdravko Donev <zdravko.donev@redis.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small comment for a missing config parameter.
|
||
The `processors` section configures the behavior of the pipeline. The [example](#example) | ||
configuration above contains the following properties: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for omitting target_data_type
both here and in the example above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for omitting
target_data_type
both here and in the example above?
@ilianiliev-redis I'm not aware of any reason - target_data_type
just wasn't in the original example, but I'll add it in now.
DOC-5282
This is the first of a few changes I'm planning to make to improve the structure of the RDI docs. It incorporates some of the suggestions from a ChatGPT review of the pipeline config page plus some other changes that I think will be helpful.
In particular:
There is also some restructuring within pages, but the technical content has not changed.
More changes to come, but I thought I'd get some feedback at this stage and check everyone is happy with what I've done so far. All suggestions welcome :-)